Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: pass port in options object #140

Merged
merged 1 commit into from
Aug 5, 2022
Merged

test: pass port in options object #140

merged 1 commit into from
Aug 5, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 4, 2022 •
edited
Loading

Pass the port to .listen() in the options object due to deprecation of variadic .listen() signature, as documented in https://medium.com/@fastifyjs/fastify-v4-ga-59f2103b5f0e

Checklist

@Fdawgs Fdawgs requested a review from mcollina August 4, 2022 08:39
@Fdawgs Fdawgs marked this pull request as ready for review August 5, 2022 07:55
@Fdawgs Fdawgs requested a review from climba03003 August 5, 2022 07:55
climba03003
climba03003 reviewed Aug 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Fdawgs Fdawgs removed the request for review from mcollina August 5, 2022 08:08
@Fdawgs Fdawgs changed the title chore: update tests and examples for fastify v4 test: pass port in options object Aug 5, 2022
@Fdawgs Fdawgs requested a review from climba03003 August 5, 2022 08:13
@climba03003 climba03003 merged commit cf29915 into master Aug 5, 2022
@Fdawgs Fdawgs deleted the chore/fastify-v4 branch August 5, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @climba03003