Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESM logging module #775

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Dec 1, 2024

Fixes #760

I also want to add support for taking the logger from the main plugin module instead, in the same way you can specify an options object as a named export on it when giving the --options flag. But I haven't decided on how to name the CLI flag and if it should have a short single letter alias. Any suggestions? – This already exists as options.logger with --options enabled. But there is an issue with deepmerge and passing an already created pino.Logger.

Checklist

@mcollina
Copy link
Member

mcollina commented Dec 7, 2024

CI is failing, could you take a look?

@segevfiner
Copy link
Contributor Author

Unrelated test failure. Likely due to upgrade of Fastify at some point introducing stricter types. Fixed it anyhow.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@mcollina mcollina merged commit d54169f into fastify:master Dec 8, 2024
11 checks passed
@segevfiner segevfiner deleted the esm-logger-module branch December 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESM logging-module
2 participants