Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vary header append #173

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix: vary header append #173

merged 1 commit into from
Jun 14, 2021

Conversation

zekth
Copy link
Member

@zekth zekth commented Jun 14, 2021

Fix #172

To fit the RFC: https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.2

Checklist

jsumners
jsumners approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mcollina
mcollina approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

could somebody issue a release with this fix?

@jsumners jsumners merged commit 72cc2bd into master Jun 14, 2021
@jsumners jsumners deleted the fix_172 branch June 14, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to append 'vary' response header rather than create a new one
3 participants
@zekth @mcollina @jsumners