Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(index): replace all * directives with gzip #189

Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix(index): replace all * directives with gzip #189

merged 2 commits into from
Oct 14, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 14, 2021

closes #187

Checklist

mcollina
mcollina reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

@Fdawgs Fdawgs requested a review from mcollina October 14, 2021 08:14
zekth
zekth approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 665e132 into fastify:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More than one wildcard directive in accept-encoding header causes fall back to br not gzip
3 participants
@Fdawgs @mcollina @zekth