Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reorganize, group, rename and improve tests suite #201

Merged
merged 16 commits into from
Dec 3, 2021

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Dec 1, 2021

Hello.

Following #198 proposal, this PR aims to :

  • reorganize tests files
  • group tests (using sub-tests) and improve tests descriptions
    • compress (global)
    • decompress (global)
    • compress (routes)
    • decompress (routes)
  • rewrite and clean up tests
    • compress (global)
    • decompress (global)
    • compress (routes)
    • decompress (routes)

Note: This PR needs a little bit of work to be completed but early reviews are welcome ^^
Should close #198

Checklist

@Fdawgs
Copy link
Member

Fdawgs commented Dec 2, 2021

Lgtm so far. This would fall under a test change not a refactor though: https://www.conventionalcommits.org/en/v1.0.0/

@Fdawgs Fdawgs changed the title refactor (test): reorganize, group, rename and improve tests suite test: reorganize, group, rename and improve tests suite Dec 2, 2021
@darkgl0w
Copy link
Member Author

darkgl0w commented Dec 2, 2021

I have finished to work on this PR and TBH it was such a pain 🤣

Lgtm so far. This would fall under a test change not a refactor though: https://www.conventionalcommits.org/en/v1.0.0/

refactor are commits, that rewrite/restructure code, and however do not change any behavior so I thought it was best suited here with a test scope 😋

@darkgl0w darkgl0w marked this pull request as ready for review December 2, 2021 21:51
@Eomm Eomm merged commit fbfd2fb into fastify:master Dec 3, 2021
@darkgl0w darkgl0w deleted the refactor-test-suite branch December 3, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants