Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace is-stream dependency with an internal isStream() utility #211

Merged
merged 3 commits into from
Jan 9, 2022
Merged

refactor: replace is-stream dependency with an internal isStream() utility #211

merged 3 commits into from
Jan 9, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Jan 8, 2022

Hello.

This PR aims to :

  • replace is-stream dependency with an internal isStream() utility. (cf.: Bump is-stream from 2.0.1 to 3.0.0 #182)
  • replace deprecated eslint-plugin-typescript with @typescript-eslint/eslint-plugin
  • upgrade package dependencies

Checklist

@darkgl0w darkgl0w changed the title Refactoring refactor: replace is-stream dependency with an internal isStream() utility Jan 8, 2022
mcollina
mcollina approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 44d4475 into fastify:master Jan 9, 2022
@darkgl0w darkgl0w deleted the refactoring branch January 9, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darkgl0w @mcollina @Eomm