Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and update minipass to 7.0.2 #265

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Fix tests and update minipass to 7.0.2 #265

merged 3 commits into from
Jul 17, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jul 16, 2023 •
edited
Loading

There were some tests that wouldn’t pass due to a type mismatch, which caused the CI to fail. I also manually updated dependencies except into-stream since it now only uses ESM.

Checklist

mcollina
mcollina approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ef412af into fastify:master Jul 17, 2023
@gurgunday gurgunday deleted the fix-tests branch July 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgunday @mcollina