Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use node:test instead of tap #302

Merged
merged 3 commits into from
Jul 15, 2024
Merged

use node:test instead of tap #302

merged 3 commits into from
Jul 15, 2024

Conversation

big-kahuna-burger
Copy link
Contributor

@big-kahuna-burger big-kahuna-burger commented Jul 13, 2024 •
edited
Loading

Checklist

mcollina
mcollina approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 13, 2024

hmm. strange. t.plan is supported since 22.2
How is it possible that node 20 passes?

I thought you need @mcollina/tspl

@big-kahuna-burger
Copy link
Contributor Author

hmm. strange. t.plan is supported since 22.2 How is it possible that node 20 passes?

I thought you need @mcollina/tspl

Backported since 20.15.0

See 20 docs here context.plan(count)

gurgunday
gurgunday approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

gurgunday
gurgunday reviewed Jul 14, 2024
View reviewed changes
.c8rc Show resolved Hide resolved
@mcollina mcollina merged commit fe97a11 into fastify:master Jul 15, 2024
11 checks passed
@big-kahuna-burger big-kahuna-burger deleted the node-test-runner branch July 15, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@big-kahuna-burger @Uzlopak @mcollina @gurgunday