make compressibleTypes user settable so custom types can be compressed #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Aug 28, 2018
|
I added 3 unit tests - check to see if it compresses if custom content type matches, that it doesn't compress if custom content type doesn't match, and that it won't compress (or break) if somebody passes in not-regex. Also cleaned up the docs for that section a bit. Kudos on your test suite. I'm new to unit testing, but the way you did it with fastify.inject was really easy to pick up. |
|
I should also mention the unit tests for custom content type are using junk values - I didn't want to use anything that might become a real content type some day. |
|
Sorry for the delay! |
|
Awesome, and thanks for the great project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The itch I'm scratching is I couldn't compress a protobuf content type, as it wasn't in mime-db or in the
compressibleTypesconstant. I was going to add it tocompressibleTypes, but that didn't seem like a sustainable solution, so I made thecompressibleTypesregex user configurable.Since the types that were in
compressibleTypesare also in mime-db, I'm guessing this is used to short circuit the mime-db check for performance. Figured overwritingcompressibleTypesthis way would be more performant than adding an additional regex check for a user passed expression (i.e. compressibleTypes.test(type) || someuserstuff.test(type)).