Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript definitions #15

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Update typescript definitions #15

merged 4 commits into from
Nov 22, 2018

Conversation

cemremengu
Copy link
Contributor

  • Add CookieSerializeOptions
  • Small fixes in package.json

@jsumners pick your poison 😈 😄

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@jsumners
Copy link
Member

Is the point of npm run typescript to generate anything? If so, does that generated something get left out of commits to the repository?

@cemremengu
Copy link
Contributor Author

It doesn't generate anything. Just sets the compiler options and runs the tests specified in tsconfig.json. So no side effects.

@jsumners
Copy link
Member

👍

I leave the decision for merging up to you guys.

@cemremengu
Copy link
Contributor Author

@mcollina patching this in if it is OK for you too

@mcollina
Copy link
Member

Go for it!

@cemremengu cemremengu merged commit 6decbe7 into master Nov 22, 2018
@cemremengu cemremengu deleted the ts-cookie branch November 22, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants