Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Fastify v2 #20

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Enable support for Fastify v2 #20

merged 1 commit into from
Dec 30, 2018

Conversation

cemremengu
Copy link
Contributor

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit aae2d8d into master Dec 30, 2018
@cemremengu cemremengu deleted the cemremengu-patch-1 branch December 30, 2018 17:38
@hersman
Copy link
Contributor

hersman commented Mar 5, 2019

I was unable to use fastify-cookie without being on Fastify v2. I previously had Fastify v1.14.2, and I kept getting a null error on FastifyRequest.req at line 30 in plugin.js.

@mcollina
Copy link
Member

mcollina commented Mar 5, 2019

What's your error? You likely need to use version 2.x of fastify-cookie.

@hersman
Copy link
Contributor

hersman commented Mar 5, 2019

Yes, but shouldn't the minimum version of Fastify be 2.0.0 in the value passed to fp() for your master branch?

@jsumners
Copy link
Member

jsumners commented Mar 5, 2019

Yes, but shouldn't the minimum version of Fastify be 2.0.0 in the value passed to fp() for your master branch?

Yes. A PR to fix would be most welcome.

@amkayondo
Copy link

I have got this error, anyway I can fix it Error: fastify-plugin - expected '^1.0.0' fastify version, '2.8.0' is installed

@jsumners
Copy link
Member

Purge your dependencies and reinstall/update them.

fastify: '>=2.0.0',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants