Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Origin within OriginFunction can be undefined #237

Merged
merged 3 commits into from
Dec 20, 2022
Merged

fix(types): Origin within OriginFunction can be undefined #237

merged 3 commits into from
Dec 20, 2022

Commits on Dec 14, 2022

  1. Callback of origin should be potentially undefined 

    In reference to fastify#236 origin cannot be assumed to always be a string. Propose making it `string | undefined` to ensure people handle it correctly. This would flag quickly in the sync example on the README that new URL can't work with undefined.
    @joshmeads
    joshmeads authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d6ca3d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Update index.d.ts 

    Co-authored-by: KaKa <climba03003@gmail.com>
    @joshmeads @climba03003
    joshmeads and climba03003 authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    52f2f58 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. restructure, add typings test

    @Uzlopak
    Uzlopak authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    25053ce View commit details
    Browse the repository at this point in the history