Fix type of OriginCallback #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a typings test? We use tsd. In the meanwhile i check if this is correct. |
marco-ippolito
approved these changes
Oct 2, 2023
renovate bot
referenced
this pull request
in tomacheese/telcheck
Oct 29, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cors](https://github.com/fastify/fastify-cors) | [`8.4.0` -> `8.4.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.0/8.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cors (@​fastify/cors)</summary> ### [`v8.4.1`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.1) [Compare Source](https://github.com/fastify/fastify-cors/compare/v8.4.0...v8.4.1) #### What's Changed - Fix type of OriginCallback by [@​ken-browning](https://github.com/ken-browning) in [https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272) - test: add `u` unicode flag to regex by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/273](https://github.com/fastify/fastify-cors/pull/273) - chore(package): explicitly declare js module type by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/274](https://github.com/fastify/fastify-cors/pull/274) - test(index): replace `typeof` undefined check by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/275](https://github.com/fastify/fastify-cors/pull/275) #### New Contributors - [@​ken-browning](https://github.com/ken-browning) made their first contribution in [https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272) **Full Changelog**: fastify/fastify-cors@v8.4.0...v8.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel
referenced
this pull request
in specfy/specfy
Nov 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cors](https://github.com/fastify/fastify-cors) | [`8.3.0` -> `8.4.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.3.0/8.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cors (@​fastify/cors)</summary> ### [`v8.4.1`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.1) [Compare Source](https://github.com/fastify/fastify-cors/compare/v8.4.0...v8.4.1) #### What's Changed - Fix type of OriginCallback by [@​ken-browning](https://github.com/ken-browning) in [https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272) - test: add `u` unicode flag to regex by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/273](https://github.com/fastify/fastify-cors/pull/273) - chore(package): explicitly declare js module type by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/274](https://github.com/fastify/fastify-cors/pull/274) - test(index): replace `typeof` undefined check by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/275](https://github.com/fastify/fastify-cors/pull/275) #### New Contributors - [@​ken-browning](https://github.com/ken-browning) made their first contribution in [https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272) **Full Changelog**: fastify/fastify-cors@v8.4.0...v8.4.1 ### [`v8.4.0`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.0) [Compare Source](https://github.com/fastify/fastify-cors/compare/v8.3.0...v8.4.0) #### What's Changed - fix documentation, onRequest is default lifecycle stage by [@​Uzlopak](https://github.com/Uzlopak) in [https://github.com/fastify/fastify-cors/pull/254](https://github.com/fastify/fastify-cors/pull/254) - perf(index): use spread over `Object.assign()` by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/257](https://github.com/fastify/fastify-cors/pull/257) - docs(readme): add plugin compatibility table by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/258](https://github.com/fastify/fastify-cors/pull/258) - test: cors headers sent when payload is stream by [@​Uzlopak](https://github.com/Uzlopak) in [https://github.com/fastify/fastify-cors/pull/260](https://github.com/fastify/fastify-cors/pull/260) - Reduce bundle size by [@​timedtext](https://github.com/timedtext) in [https://github.com/fastify/fastify-cors/pull/266](https://github.com/fastify/fastify-cors/pull/266) - chore(deps-dev): bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.62.0 to 6.4.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/fastify/fastify-cors/pull/267](https://github.com/fastify/fastify-cors/pull/267) - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/fastify/fastify-cors/pull/268](https://github.com/fastify/fastify-cors/pull/268) - test: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/269](https://github.com/fastify/fastify-cors/pull/269) - refactor(vary): use word character inside regex character class by [@​Fdawgs](https://github.com/Fdawgs) in [https://github.com/fastify/fastify-cors/pull/270](https://github.com/fastify/fastify-cors/pull/270) #### New Contributors - [@​timedtext](https://github.com/timedtext) made their first contribution in [https://github.com/fastify/fastify-cors/pull/266](https://github.com/fastify/fastify-cors/pull/266) **Full Changelog**: fastify/fastify-cors@v8.3.0...v8.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Open
1 task
](https://renovatebot.com){kind=link}
This was referenced Sep 8, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
OriginCallbackfunction states:This corrects the type. It is possible that the second parameter should be typed as
ValueOrArray<OriginType> | Promise<ValueOrArray<OriginType>>. That last sentence is ambiguous and I haven't consulted the implementation.