Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate from tap to node:test #151

Merged
merged 2 commits into from
Sep 19, 2024
Merged

refactor: migrate from tap to node:test #151

merged 2 commits into from
Sep 19, 2024

Conversation

asomethings
Copy link
Contributor

Removes tap and uses node:test.

fastify/fastify#5555

Checklist

dancastillo
dancastillo approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dancastillo
Copy link
Member

@asomethings can you fix merge conflict

@asomethings
Copy link
Contributor Author

@dancastillo Done!

@dancastillo dancastillo merged commit 5b273b4 into fastify:main Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@dancastillo dancastillo dancastillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomethings @dancastillo @gurgunday