Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix return value with custom nonces example #241

Merged
merged 1 commit into from
Dec 30, 2023
Merged

docs: fix return value with custom nonces example #241

merged 1 commit into from
Dec 30, 2023

Conversation

big-kahuna-burger
Copy link
Contributor

Documentation fix for custom nonces when generated by helmet itself

Just follow the original docs and see that it actually returns nonce-... in the arrow fn,
or source and see how element(req, res) gets joined into CSP header.

Checklist

@big-kahuna-burger big-kahuna-burger changed the title docs: fix ret value with custom nonces example docs: fix return value with custom nonces example Dec 30, 2023
mcollina
mcollina approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 440fe10 into fastify:master Dec 30, 2023
@big-kahuna-burger big-kahuna-burger deleted the fix-docs branch December 30, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-kahuna-burger @mcollina