-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move mongodb to devDeps and add it to peerDeps #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
If I understand peerDeps correctly, this risks not installing mongoDB if a user installs packages using npm ci --omit=dev
The default value of omit option is dev. |
Unfortunately the minimum supported version of this module is Node v14. |
Generically we prefer to stay away from peerdependencies because they create more problems than what they are worth. |
For |
Oof, that's correct, good catch A PR that downgrades it is welcome |
I would really prefer avoiding peerDependencies anyway. They are just a source of headaches for maintainers. |
Node v14 isn't mantained, when it will be removed? |
When Fastify v5 is released (probably by the end of this year) |
I am closing the PR because we avoid using peerDependencies in any case. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct