-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partly closes #496: add missing type #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a PR! Can you please add a unit test? We use tsd for our types.
Signed-off-by: hash0000 <hash.apps.010@gmail.com>
Do the |
I think so, but verify with the code. |
Signed-off-by: hash0000 <hash00000@icloud.com>
I'm not sure, but did you mean this test? |
Lets run the tests. Your holistic approach to also test the same thing in javascript is apprecaited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: hash0000 <hash00000@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix type missing. More info in issue #496.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct