Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partly closes #496: add missing type #502

Merged
merged 5 commits into from
Jan 1, 2024
Merged

Partly closes #496: add missing type #502

merged 5 commits into from
Jan 1, 2024

Conversation

hash0000
Copy link
Contributor

@hash0000 hash0000 commented Dec 27, 2023

Fix type missing. More info in issue #496.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for our types.

Signed-off-by: hash0000 <hash.apps.010@gmail.com>
@mcollina
Copy link
Member

@hash0000
Copy link
Contributor Author

hash0000 commented Dec 27, 2023

Do the files() and file() support all options from the FastifyMultipartBaseOptions interface (except throwFileSizeLimit and limits, of course)?

@mcollina
Copy link
Member

I think so, but verify with the code.

Signed-off-by: hash0000 <hash00000@icloud.com>
@hash0000
Copy link
Contributor Author

hash0000 commented Dec 27, 2023

I'm not sure, but did you mean this test?

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 27, 2023

Lets run the tests. Your holistic approach to also test the same thing in javascript is apprecaited.

types/index.test-d.ts Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2430619 into fastify:master Jan 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants