Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): Update to next 9.3.1 #83

Merged
merged 4 commits into from
Apr 21, 2020

Conversation

Jule-
Copy link
Contributor

@Jule- Jule- commented Mar 25, 2020

Integrate Next.js breaking changes

Add package-lock.json into source control (if you do not understand the usefulness of this file I recommend that you read this npm-package-lock.json).
=> while it is useful for apps it becomes irrelevant for packages since ignored by npm in dependency trees. Committing it could hide issues that third party could have when adding this package as new dependency since it will install last versions of dependencies following semver rules.

Checklist

  • run npm run test
  • tests are included (unchanged)
  • documentation is changed or added (no need)
  • commit message and code follows Code of conduct

Integrate Next.js breaking changes
@tmayr
Copy link

tmayr commented Apr 14, 2020

Will this be merged at some point Anything we can do to speed it up?

.gitignore Show resolved Hide resolved
@simonecorsi
Copy link

simonecorsi commented Apr 20, 2020

Hey, thanks for the fixes! Any chances on advancing this PR? Is there some help needed ? I'm using your fixes as a monkey patch and would be cool having it merged 😄

If the problem is the package-lock maybe you can move in a separate issue so you both can discuss it separately!

@Jule-
Copy link
Contributor Author

Jule- commented Apr 21, 2020

@Kirkhammetz Yes sorry it runs out of my mind, thanks for the ping, push incoming. 😉

@Jule-
Copy link
Contributor Author

Jule- commented Apr 21, 2020

@mcollina anything else or it is good for you?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still need the removal of package-lock, thanks.

@Jule-
Copy link
Contributor Author

Jule- commented Apr 21, 2020

🤦 omg... No comment. 😅

@Jule-
Copy link
Contributor Author

Jule- commented Apr 21, 2020

Hum I am confused with Travis error log, does it seems relevant to you? Or it is purely CI issue?

{ Error: EEXIST: file already exists, mkdir '/home/travis/build/fastify/fastify-nextjs/.next'
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/home/travis/build/fastify/fastify-nextjs/.next' }

@Jule-
Copy link
Contributor Author

Jule- commented Apr 21, 2020

Well the reason is because Next.js requirements is NodeJS 10.13 or later.
https://nextjs.org/docs#system-requirements

Related issue: vercel/next.js#11601

@mcollina Want me to patch .travis.yml by removing all build tests under this version?

@mcollina
Copy link
Member

Want me to patch .travis.yml by removing all build tests under this version?

Please do, thx

Following Next.js requirements, dropping node 8 support.
See https://nextjs.org/docs#system-requirements
Add support to node 12 and 13.

BREAKING CHANGE: Node 8 is no longer supported
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7559925 into fastify:update-next-types Apr 21, 2020
mcollina pushed a commit that referenced this pull request Apr 21, 2020
* update packages

* feat(next): Update to next 9.3.1 (#83)

* feat(next): Update to next 9.3.1

Integrate Next.js breaking changes

* chore(gitignore): Revert changes for package-lock.json in .gitignore

* chore(gitignore): Actually remove package-lock.json for real...

* ci(node): Update node supported versions

Following Next.js requirements, dropping node 8 support.
See https://nextjs.org/docs#system-requirements
Add support to node 12 and 13.

BREAKING CHANGE: Node 8 is no longer supported

Co-authored-by: Jule- <Jule-@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants