-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): Update to next 9.3.1 #83
Conversation
Integrate Next.js breaking changes
Will this be merged at some point Anything we can do to speed it up? |
Hey, thanks for the fixes! Any chances on advancing this PR? Is there some help needed ? I'm using your fixes as a monkey patch and would be cool having it merged 😄 If the problem is the |
@Kirkhammetz Yes sorry it runs out of my mind, thanks for the ping, push incoming. 😉 |
@mcollina anything else or it is good for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still need the removal of package-lock, thanks.
🤦 omg... No comment. 😅 |
Hum I am confused with Travis error log, does it seems relevant to you? Or it is purely CI issue?
|
Well the reason is because Next.js requirements is NodeJS 10.13 or later. Related issue: vercel/next.js#11601 @mcollina Want me to patch |
Please do, thx |
Following Next.js requirements, dropping node 8 support. See https://nextjs.org/docs#system-requirements Add support to node 12 and 13. BREAKING CHANGE: Node 8 is no longer supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* update packages * feat(next): Update to next 9.3.1 (#83) * feat(next): Update to next 9.3.1 Integrate Next.js breaking changes * chore(gitignore): Revert changes for package-lock.json in .gitignore * chore(gitignore): Actually remove package-lock.json for real... * ci(node): Update node supported versions Following Next.js requirements, dropping node 8 support. See https://nextjs.org/docs#system-requirements Add support to node 12 and 13. BREAKING CHANGE: Node 8 is no longer supported Co-authored-by: Jule- <Jule-@users.noreply.github.com>
Integrate Next.js breaking changes
Add package-lock.json into source control (if you do not understand the usefulness of this file I recommend that you read this npm-package-lock.json).=> while it is useful for apps it becomes irrelevant for packages since ignored by
npm
in dependency trees. Committing it could hide issues that third party could have when adding this package as new dependency since it will install last versions of dependencies following semver rules.Checklist
npm run test