-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Fastify v5 #1193
Updates for Fastify v5 #1193
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Typing issues are due to conflicting differences between There is a TODO in the code here that would go some way to fixing it: fastify-passport/src/session-managers/SecureSessionManager.ts Lines 57 to 58 in 3a05ee0
Have raised issue in fastify-secure-session to action this TODO so we can tidy that up. If there's any urgency to this PR then we could approve it as-is with a follow-up ticket here to clean up once the types are improved on secure-session |
I've also had a brief investigation of the types issues, and have created a I've opened a PR against this PR that resolves the type issues (except the |
* chore: fix type issues * lint * Fix linting I'll investigate why this rule needs to be disabled when I get a chance. Signed-off-by: Rob Walker <hi@robwalker.co> * linting --------- Signed-off-by: Rob Walker <hi@robwalker.co>
@dancastillo @Uzlopak @climba03003 fancy a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one small comment
Co-authored-by: Dan Castillo <dan.castillo@jasper.ai> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
I had to add a bunch of
@ts-expect-error
to make things pass, as I have no time to understand why the types here are not behaving.Checklist
npm run test
andnpm run benchmark
and the Code of conduct