Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fastify v4 compatibility #183

Merged
merged 1 commit into from
Jun 15, 2022
Merged

chore: fastify v4 compatibility #183

merged 1 commit into from
Jun 15, 2022

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Jun 15, 2022

This PR introduces the (non functional) changes needed to make this package work with Fastify v4 (only docs and tests). Notes this uses as merge base the dependabot branch.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simoneb
Copy link
Contributor Author

simoneb commented Jun 15, 2022

if somebody could merge this PR then we can check that the dependabot one also works and then do a release

@simoneb
Copy link
Contributor Author

simoneb commented Jun 15, 2022

btw this repo could be under the fastify-plugins team umbrella, and I could do those things myself if it was :)

@climba03003 climba03003 merged commit 7bdbf87 into fastify:dependabot/npm_and_yarn/fastify-4.0.1 Jun 15, 2022
@jsumners
Copy link
Member

This would be under the libraries team, as this isn't really a plugin. I can make that happen and get you on that team. Agreed, @mcollina ?

@simoneb simoneb deleted the dependabot/npm_and_yarn/fastify-4.0.1 branch June 15, 2022 16:34
@simoneb
Copy link
Contributor Author

simoneb commented Jun 15, 2022

oh ok gotcha, I didn't know there was another team for this. I don't mind, I not contributing that often around here anyway

@mcollina
Copy link
Member

go for it @jsumners

@jsumners
Copy link
Member

Done. I have some work to do with getting some other libraries into the npm org, but this one is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants