Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootPath overload parameter to sendFile function #118

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Add rootPath overload parameter to sendFile function #118

merged 1 commit into from
Jan 26, 2020

Conversation

chris-shaw-2011
Copy link
Contributor

For my project the root path is user configurable and can be changed without a server restart, so I needed a way to specify the path dynamically when a file is requested.

This change also allows files to be served from more than one root path

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add some tests for this new feature? Also, it seems CI is not happy

@chris-shaw-2011
Copy link
Contributor Author

I added a test and fixed the CI issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

index.js Outdated Show resolved Hide resolved
test/static.test.js Show resolved Hide resolved
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants