Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint #415

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix eslint #415

merged 3 commits into from
Oct 5, 2023

Conversation

gurgunday
Copy link
Member

More information: fastify/fastify-multipart#485

Checklist

tsconfig.eslint.json Outdated Show resolved Hide resolved
"no-use-before-define": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-floating-promises": "off",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we replaced @typescript-eslint/no-misused-promises with this? they are different

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I thought it was unnecessarily disabling the rule instead of enabling it

@mcollina mcollina merged commit f169915 into fastify:master Oct 5, 2023
15 checks passed
@gurgunday gurgunday deleted the fix-eslint branch October 5, 2023 20:52
renovate bot referenced this pull request in redwoodjs/redwood Nov 15, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://github.com/fastify/fastify-static) |
[`6.11.2` ->
`6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.2/6.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.11.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.11.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v6.12.0`](https://github.com/fastify/fastify-static/releases/tag/v6.12.0)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.11.2...v6.12.0)

#### What's Changed

- fix eslint by [@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/415](https://github.com/fastify/fastify-static/pull/415)
- refactor: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/418](https://github.com/fastify/fastify-static/pull/418)
- refactor: remove unused bindings by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/417](https://github.com/fastify/fastify-static/pull/417)
- perf(index): check set size over converting to array to check length
by [@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/416](https://github.com/fastify/fastify-static/pull/416)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/419](https://github.com/fastify/fastify-static/pull/419)
- test: replace `typeof` undefined check by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/420](https://github.com/fastify/fastify-static/pull/420)

**Full Changelog**:
fastify/fastify-static@v6.11.2...v6.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar referenced this pull request in redwoodjs/redwood Nov 16, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://github.com/fastify/fastify-static) |
[`6.11.2` ->
`6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.2/6.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.11.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.11.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

[`v6.12.0`](https://github.com/fastify/fastify-static/releases/tag/v6.12.0)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.11.2...v6.12.0)

- fix eslint by [@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/415](https://github.com/fastify/fastify-static/pull/415)
- refactor: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/418](https://github.com/fastify/fastify-static/pull/418)
- refactor: remove unused bindings by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/417](https://github.com/fastify/fastify-static/pull/417)
- perf(index): check set size over converting to array to check length
by [@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/416](https://github.com/fastify/fastify-static/pull/416)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/419](https://github.com/fastify/fastify-static/pull/419)
- test: replace `typeof` undefined check by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/420](https://github.com/fastify/fastify-static/pull/420)

**Full Changelog**:
fastify/fastify-static@v6.11.2...v6.12.0

</details>

---

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in specfy/specfy Dec 4, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://github.com/fastify/fastify-static) |
[`6.10.2` ->
`6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v6.12.0`](https://github.com/fastify/fastify-static/releases/tag/v6.12.0)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.11.2...v6.12.0)

#### What's Changed

- fix eslint by [@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/415](https://github.com/fastify/fastify-static/pull/415)
- refactor: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/418](https://github.com/fastify/fastify-static/pull/418)
- refactor: remove unused bindings by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/417](https://github.com/fastify/fastify-static/pull/417)
- perf(index): check set size over converting to array to check length
by [@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/416](https://github.com/fastify/fastify-static/pull/416)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/419](https://github.com/fastify/fastify-static/pull/419)
- test: replace `typeof` undefined check by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/420](https://github.com/fastify/fastify-static/pull/420)

**Full Changelog**:
fastify/fastify-static@v6.11.2...v6.12.0

###
[`v6.11.2`](https://github.com/fastify/fastify-static/releases/tag/v6.11.2)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.11.1...v6.11.2)

#### What's Changed

- fix: allow fallback to fastify@2.22 route config by
[@&#8203;climba03003](https://github.com/climba03003) in
[https://github.com/fastify/fastify-static/pull/410](https://github.com/fastify/fastify-static/pull/410)

**Full Changelog**:
fastify/fastify-static@v6.11.1...v6.11.2

###
[`v6.11.1`](https://github.com/fastify/fastify-static/releases/tag/v6.11.1)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.11.0...v6.11.1)

#### What's Changed

- Remove test/content-type/sample.jpg.br by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/fastify/fastify-static/pull/400](https://github.com/fastify/fastify-static/pull/400)
- build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-static/pull/401](https://github.com/fastify/fastify-static/pull/401)
- added some small code improvements by
[@&#8203;turnerran](https://github.com/turnerran) in
[https://github.com/fastify/fastify-static/pull/399](https://github.com/fastify/fastify-static/pull/399)
- (more) small performance/clarity improvements by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/405](https://github.com/fastify/fastify-static/pull/405)
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/407](https://github.com/fastify/fastify-static/pull/407)
- use native stream by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/408](https://github.com/fastify/fastify-static/pull/408)
- Fix request route config deprecation warnings by
[@&#8203;TTPO100AJIEX](https://github.com/TTPO100AJIEX) in
[https://github.com/fastify/fastify-static/pull/409](https://github.com/fastify/fastify-static/pull/409)

#### New Contributors

- [@&#8203;turnerran](https://github.com/turnerran) made their first
contribution in
[https://github.com/fastify/fastify-static/pull/399](https://github.com/fastify/fastify-static/pull/399)
- [@&#8203;TTPO100AJIEX](https://github.com/TTPO100AJIEX) made their
first contribution in
[https://github.com/fastify/fastify-static/pull/409](https://github.com/fastify/fastify-static/pull/409)

**Full Changelog**:
fastify/fastify-static@v6.11.0...v6.11.1

###
[`v6.11.0`](https://github.com/fastify/fastify-static/releases/tag/v6.11.0)

[Compare
Source](https://github.com/fastify/fastify-static/compare/v6.10.2...v6.11.0)

#### What's Changed

- Update README with 404+wildcard behavior by
[@&#8203;Ethan-Arrowood](https://github.com/Ethan-Arrowood) in
[https://github.com/fastify/fastify-static/pull/390](https://github.com/fastify/fastify-static/pull/390)
- add tests for
[#&#8203;234](https://github.com/fastify/fastify-static/issues/234) by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/391](https://github.com/fastify/fastify-static/pull/391)
- remove linting from the test script by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/394](https://github.com/fastify/fastify-static/pull/394)
- Remove redundant parameter by
[@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/395](https://github.com/fastify/fastify-static/pull/395)
- build(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)
from 2.34.0 to 6.2.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-static/pull/397](https://github.com/fastify/fastify-static/pull/397)
- add url type by [@&#8203;gurgunday](https://github.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/398](https://github.com/fastify/fastify-static/pull/398)

#### New Contributors

- [@&#8203;Ethan-Arrowood](https://github.com/Ethan-Arrowood) made
their first contribution in
[https://github.com/fastify/fastify-static/pull/390](https://github.com/fastify/fastify-static/pull/390)
- [@&#8203;gurgunday](https://github.com/gurgunday) made their first
contribution in
[https://github.com/fastify/fastify-static/pull/391](https://github.com/fastify/fastify-static/pull/391)

**Full Changelog**:
fastify/fastify-static@v6.10.2...v6.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants