-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible to passthrough functions to the swagger-initializer.js #37
Conversation
Docs would need to be updated to mention no support for Maps, Sets etc. until they're added, right? |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Ok, seems like you have interest in this solution. Added Maps and Sets. but tbh... they werend supported till now neither. I think the solution is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let wait a bit for the others to review before merging.
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as Climba said, need some more eyes on it.
Is the CI linting failure an issue?
Seems like a bug of |
I investigated why suddenly linting is failing, and I have no clue. Locally it works. If I remove the standard rules in package.json i get the same error as in the ci. |
The linting issue can be found here estools/esquery#135 |
Ok. Linting is working now after equery was fixed |
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@mcollina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No I don't think it's needed at this time. |
@Eomm PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #25
I know that the coverage is failing, but writing 100% test coverage would be a waste of time if the approach would not be accepted.
So currently we JSON.stringify uiConfig and initOAuth which is basically removing functions as functions are not per definition serializable. But with my super simple serializiation function, I can serialize an Object as best as possible. Yeah sure... ES6 Maps and Sets and what not are not supported or yet. But whatever. Supplying the initOAuth and uiConfig per swagger-initialization.js so we can support functions.
Removes the initOAuth and the uiConfig routes as they dont need to be fetched again.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct