-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose named export (fix TypeScript>=4.8 with native ESM) #207
Conversation
Pull Request Test Coverage Report for Build 4055827173Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@climba03003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't block for a named export with shorten name.
Co-authored-by: KaKa <climba03003@gmail.com>
Is this a real life? i will finally be able to update TS? LGTM |
I've noticed a couple of things:
Also I've just created a pure-ESM version of this project under the name fluent-json-schema-es where you can use the By doing that I saw that a double-module package (bot ESM and CJS code inside the same package) could potentially fix the issue with TypeScript entirely. I suggest What are your thoughts about It? I will be happy to make this change and deprecate |
Sure, please open a separate PR. 😄
See fastify/fastify#2847 for ESM discussion. |
when's release? |
Checklist
npm run test
and the Code of conduct