Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose named export (fix TypeScript>=4.8 with native ESM) #207

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

greguz
Copy link
Contributor

@greguz greguz commented Jan 31, 2023

Checklist

@coveralls
Copy link

coveralls commented Jan 31, 2023

Pull Request Test Coverage Report for Build 4055827173

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3857247421: 0.0%
Covered Lines: 405
Relevant Lines: 405

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 31, 2023

@climba03003
;/

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't block for a named export with shorten name.

Co-authored-by: KaKa <climba03003@gmail.com>
@mcollina mcollina requested a review from aboutlo February 1, 2023 11:52
@Inviz
Copy link

Inviz commented Feb 3, 2023

Is this a real life? i will finally be able to update TS? LGTM

@mcollina
Copy link
Member

mcollina commented Feb 5, 2023

@Fdawgs @aboutlo PTAL

@greguz
Copy link
Contributor Author

greguz commented Feb 7, 2023

I've noticed a couple of things:

  • The Prettier badge is wrong, I see this repo uses Standard for linting. May I update the badge?
  • There's no files field inside the package.json, so all test files (and much more) are packaged and shipped to NPM. May add this field?

Also I've just created a pure-ESM version of this project under the name fluent-json-schema-es where you can use the import S from 'fluent-json-schema-es syntax freely.

By doing that I saw that a double-module package (bot ESM and CJS code inside the same package) could potentially fix the issue with TypeScript entirely. I suggest rollup to do the ESM>CJS conversion.

What are your thoughts about It? I will be happy to make this change and deprecate fluent-json-schema-es.

@Fdawgs
Copy link
Member

Fdawgs commented Feb 7, 2023

* The `Prettier` badge is wrong, I see this repo uses `Standard` for linting. May I update the badge?

Sure, please open a separate PR. 😄

* There's no `files` field inside the `package.json`, so all test files (and much more) are packaged and shipped to `NPM`. May add this field?

See fastify/skeleton#42

Also I've just created a pure-ESM version of this project under the name fluent-json-schema-es where you can use the import S from 'fluent-json-schema-es syntax freely.

By doing that I saw that a double-module package (bot ESM and CJS code inside the same package) could potentially fix the issue with TypeScript entirely. I suggest rollup to do che ESM>CJS conversion.

What are your thoughts about It? I will be happy to make this change and deprecate fluent-json-schema-es.

See fastify/fastify#2847 for ESM discussion.

@greguz greguz changed the title Expose named export (fix TypeScript>=1.8 with native ESM) Expose named export (fix TypeScript>=4.8 with native ESM) Feb 8, 2023
@aboutlo aboutlo merged commit 8a358b2 into fastify:master Feb 13, 2023
@Inviz
Copy link

Inviz commented Feb 22, 2023

when's release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants