doc: update information about target property

[groozin]

Fixes #491

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Uzlopak]

Why?

[groozin]

Shouldn't we keep the tests artifacts from tap out of repository?

[Uzlopak]

@Fdawgs

does tap generates artifacts?

[groozin]

Here is what I am getting after running npm test

> git status
On branch main
Your branch is behind 'origin/main' by 2 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   README.md

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.tap/

no changes added to commit (use "git add" and/or "git commit -a")

[Uzlopak]

Thats strange, because we have a general .gitignore file and if tap generates artifacts we should also cover them in that file. Thats why I am pinging @Fdawgs

[Fdawgs]

@Uzlopak The general .gitignore doesn't have this as I don't believe any other Fastify repo generates tap artefacts.

This repo isn't kept in line with the other ones though as it's a GitHub Action and I don't know what it does/doesn't need to ignore.

[groozin]

I am happy to remove the .tap/ from the ignore and just not adding the artifacts to the PR. This PR is really just about the doc/readme. And I don't want to introduce additional confusion here.
I guess the topic of what to put in gitignore can be solved elsewhere. WDYT @Uzlopak @Fdawgs ?

[Fdawgs]

Probably best to just add your doc changes, thanks @groozin.

[Uzlopak]

Please remove unnecessary changes

[simoneb]

LGTM

[simoneb]

I'm happy with the changes but @Uzlopak @Fdawgs please shout if you'd like to remove the .tap exclusion in .gitignore. I don't see any harm in leaving it there though

[Uzlopak]

I dont see any harm either. Just being strange that they are generated. Didnt see them till today. Only worrying me is the build dist file. Nothing against @groozin but we have to be careful and ensure that there is not a sec. vuln. Introduced by bike shedding.

[groozin]

the dist comes from the husky hook - I assumed that was by design. I can try and maybe do it in another way.

[simoneb]

good point @Uzlopak , @groozin is working with me so I don't have any concerns in that regard, but yes @groozin revert the change in the dist folder please, if there is a change needed it will be done by the publishing process

[simoneb]

@Uzlopak @Fdawgs if you're happy with the change, merge away

[Uzlopak]

LGTM