Release the holder if the response has finished

[delvedor]

As titled.

[mcollina]

LGTM. Is this affecting benchmarks at all?

[delvedor]

@mcollina I didn't check, but since we are adding just an if condition (which is just a boolean check) it should not affect the performances.

[mcollina]

This should be documented somewhere. Also, what would happen if next() is called twice or after release().

[delvedor]

Also, what would happen if next() is called twice or after release().

If you call twice next() you will get Cannot read property 'originalUrl' of null.

This should be documented somewhere.

Document what?
If a previous middleware calls res.end the next one will never run? Shouldn't this be implicit? 🤔

[mcollina]

ok ;). Let’s ship this.. semver-minor? Il giorno sab 20 gen 2018 alle 17:45 Tomas Della Vedova < notifications@github.com> ha scritto:

…

Also, what would happen if next() is called twice or after release(). If you call twice next() you will get Cannot read property 'originalUrl' of null. This should be documented somewhere. Document what? If a previous middleware calls res.end the next one will never run? Shouldn't this be implicit? 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL4-snUrUcPIHWpwFw63rE6RxafBw_ks5tMhgSgaJpZM4RlfUa> .