improve performance (#70)

fastify · Dec 4, 2022 · 005053d · 005053d
1 parent bf73ac3
commit 005053d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/benchmarks/warn.js b/benchmarks/warn.js
@@ -0,0 +1,17 @@
+'use strict'
+
+const { Suite } = require('benchmark')
+const warning = require('..')()
+
+warning.create('FastifyWarning', 'FST_ERROR_CODE_1', 'message')
+warning.create('FastifyWarning', 'FST_ERROR_CODE_2', 'message')
+warning.create('FastifyWarning', 'FST_ERROR_CODE_3', 'message')
+new Suite()
+  .add('warn', function () {
+    warning.emit('FST_ERROR_CODE_1')
+    warning.emit('FST_ERROR_CODE_3')
+  })
+  .on('cycle', function (event) {
+    console.log(String(event.target))
+  })
+  .run()
diff --git a/index.js b/index.js
@@ -44,8 +44,8 @@ function processWarning () {
   }
 
   function emit (code, a, b, c) {
-    if (codes[code] === undefined) throw new Error(`The code '${code}' does not exist`)
     if (emitted.get(code) === true) return
+    if (codes[code] === undefined) throw new Error(`The code '${code}' does not exist`)
     emitted.set(code, true)
 
     const warning = codes[code](a, b, c)

diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
   },
   "homepage": "https://github.com/fastify/fastify-warning#readme",
   "devDependencies": {
+    "benchmark": "^2.1.4",
     "jest": "^29.0.1",
     "standard": "^17.0.0",
     "tap": "^16.3.0",