Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for fastify v5 #61

Merged
merged 3 commits into from
Apr 17, 2024
Merged

update for fastify v5 #61

merged 3 commits into from
Apr 17, 2024

Conversation

gurgunday
Copy link
Member

No description provided.

mcollina
mcollina requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just extend the supported range, there is no need to drop old nodes for this.

@gurgunday
Copy link
Member Author

gurgunday commented Apr 17, 2024 •
edited
Loading

We must leave tap at v16 then, or move to tape

@mcollina
Copy link
Member

tape would be best for this.

@gurgunday gurgunday changed the base branch from next to master April 17, 2024 13:55
@gurgunday gurgunday requested a review from mcollina April 17, 2024 13:55
mcollina
mcollina approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b030f72 into fastify:master Apr 17, 2024
10 checks passed
@gurgunday gurgunday deleted the v5 branch April 17, 2024 14:03
@gurgunday gurgunday mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgunday @mcollina