Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Commit

Permalink
Fixed not correctly escaping the password when using transporter
Browse files Browse the repository at this point in the history
  • Loading branch information
KrauseFx committed Nov 14, 2014
1 parent 94bd287 commit 9cc8ced
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions lib/deliver/itunes_transporter.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'pty'

require 'shellwords'
require 'deliver/password_manager'


Expand Down Expand Up @@ -48,8 +48,10 @@ def download(app, dir = nil)

result = execute_transporter(command)

if result
if result and File.directory?"/tmp/#{app.apple_id}.itmsp"
Helper.log.info "Successfully downloaded the latest package from iTunesConnect.".green
else
Helper.log.fatal "Could not download metadata from iTunes Connect. Do you have special characters in your password (Like ' or \")?"
end

result
Expand Down Expand Up @@ -159,7 +161,7 @@ def build_upload_command(username, password, source = "/tmp")
end

def escaped_password(password)
password.gsub('$', '\\$')
Shellwords.escape(password)
end

end
Expand Down

0 comments on commit 9cc8ced

Please sign in to comment.