Fix building tvOS apps #195
Conversation
| @@ -62,7 +62,7 @@ def self.detect_scheme | |||
| # Is it an iOS device or a Mac? | |||
| def self.detect_platform | |||
| return if Gym.config[:destination] | |||
| platform = Gym.project.mac? ? "OS X" : "iOS" # either `iOS` or `OS X` | |||
| platform = Gym.project.mac? ? "OS X" : Gym.project.tvos? ? "tvOS" : "iOS" | |||
There was a problem hiding this comment.
Ternary operators must not be nested. Prefer if/else constructs instead.
There was a problem hiding this comment.
Too many ? in one line, please change that to multi-line
There was a problem hiding this comment.
Multiline ternary, or if/else?
|
Hey @tmm1, thanks for the PR. Did you test |
|
Yes, submitted through TestFlight without a problem. The only issue I've noticed is that it looks like all files are rebuilt every time I run gym, even though |
|
@tmm1 Yeah, that's a separate issue with |
| @@ -62,7 +62,13 @@ def self.detect_scheme | |||
| # Is it an iOS device or a Mac? | |||
| def self.detect_platform | |||
| return if Gym.config[:destination] | |||
| platform = Gym.project.mac? ? "OS X" : "iOS" # either `iOS` or `OS X` | |||
| platform = if Gym.project.mac? | |||
| "OS X" | |||
There was a problem hiding this comment.
Use 2 (not -9) spaces for indentation.
Bummer. Got any links handy? |
|
Could you squash the commits, before I can merge it 👍 |
|
Done. |
|
Ping. |
|
Sorry for the delay, and thanks for updating the PR @tmm1 👍 |
|
I saw this was merged into master however I am still seeing the "gym doesn't suppoort tvOS projects yet, we're working on adding this feature!". Is there still some development going on for this feature, or is something else wrong, and i should be able to make build for tvOS? |
|
@mgazdich Yeah, I just noticed I haven't pushed a new release in a while, will do that right now 👍 |
|
It's live 🚀 https://github.com/fastlane/gym/releases/tag/1.5.0, thanks again for letting me know @mgazdich 👍 |
|
Absolutely! I just ran an update. One little thing I am notice however, is when i have the default platform specified in my fastfile as tvos is gives me the same "doesnt support" error. Any incite? And if there is a better avenue to communicating with you, by all means. Is there a need to update fastlane at all? Or is just running the gem install for gym enough? |
|
@mgazdich Please submit a separate GitHub issue and share your |
This lets
gymbuild tvos apps