This repository has been archived by the owner on Oct 2, 2018. It is now read-only.
Mark Xcode archives generated by gym with extended attribute #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,7 @@ | |||
| require 'pty' | |||
| require 'open3' | |||
| require 'fileutils' | |||
| require 'shellwords' | |||
There was a problem hiding this comment.
Does this need to be added to the gemspec?
There was a problem hiding this comment.
Hmmm, excellent question. Other fastlane tools (fastlane, sign, snapshot) have .rb files that similarly require 'shellwords', but do not declare it in the gemspec. That's what I modeled this on, but perhaps I'm misunderstanding what needs to go in the gemspec?
There was a problem hiding this comment.
Good call, AFAIK it's in the standard library and doesn't need to be added. We use it already in gym
|
Looks good to me, test succeed (just one job got stuck), ready to 🚢 |
mpirri
added a commit
that referenced
this pull request
Feb 11, 2016
Mark Xcode archives generated by gym with extended attribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.