Initial support for Mac apps submission #545
Conversation
| ) | ||
| elsif options[:pkg] | ||
| package_path = FastlaneCore::PkgUploadPackageBuilder.new.generate( | ||
| app_id: options[:app].apple_id, |
There was a problem hiding this comment.
Indent the first parameter one step more than the start of the previous line.
|
This looks great already, thanks for all your amazing contribution 👍 |
olegoid
changed the title
|
Hey @KrauseFx, thanks for your comments! Actually I think this PR is ready for review. |
| @@ -36,7 +36,8 @@ def run | |||
| c.action do |args, options| | |||
| options = FastlaneCore::Configuration.create(Deliver::Options.available_options, options.__hash__) | |||
| loaded = options.load_configuration_file("Deliverfile") | |||
| loaded = true if options[:description] || options[:ipa] # do we have *anything* here? | |||
| options.verify_conflicts | |||
There was a problem hiding this comment.
Do you think there is a good way to change this so that you don't have to call this method manually? Maybe we could check it whenever we access a value? On the other hand I can see how this might cause problems when setting values on the run time.
I'm okay with leaving it like this, just want to your thought on this
There was a problem hiding this comment.
Hey @KrauseFx, I think that this verification should be implemented on fastlane_core level and verify_conflicts should be called each time we load options values(from CLI, config file or setting defaults).
I added a few updates to conflicting options PR wrt this.
Thanks again for highlighting it!
|
Looks great, let's wait until the fastlane_core PR is done, then we can merge and release this, thanks for your contribution 🚀 |
Update readme with instructions about pkg files submission Update Deliverfile.md Update Deliverfile.md again Add options conflict verification after reading from Deliveryfile Improve options conflict error messages Fix code formatting issue Update README.md - prefix OS X with Mac Now options verified automatically in fastlane_core module
Initial support for Mac apps submission
|
Perfect, thank you so much 👍 |
WARNING: this PR requires conflicting options functionality from another pull request to
fastlane_coreThis PR adds initial support for OS X apps submission. With this patch users of
delivershould be able to upload signedpkgfiles using--pkgkey or it's short version-c(You may be wondering whyc? Well it's mostly becausep,kandgare occupied already. If you have better idea of naming please let me know).Feedback and comments are greatly appreciated!