Use conflicting options mechanism for workspace and project paths #205
Conversation
* Use conflicting options mechanism for workspace and project paths * Update specs
| end, | ||
| conflicting_options: [:project], | ||
| conflict_block: proc do |value| | ||
| UI.user_error!("You can only pass either a 'workspace' or a '#{value.key}', not both") |
There was a problem hiding this comment.
Why not just write project instead of value.key
There was a problem hiding this comment.
@KrauseFx Current implementation works not only for :project but for other potential conflicts as well!
Otherwise, In case if new conflicting options will be added to gym(or we will find new tuples of conflicting options) user error message should be changed in order to reflect the real cause of the conflict.
Use conflicting options mechanism for workspace and project paths
|
Sounds good, thanks for the pull request 👍 |
|
Thanks for review @KrauseFx! |
|
This actually causes problems when values are automatically detected (e.g. when there is a workspace and a project in the current directory, both will be set I think) |
|
I don't understand this error message here: #212 (comment) |
|
Hey @KrauseFx, I'll take a look later today. Thanks for highlighting it! |
In this PR I added new mechanism for handling conflicts between
workspaceandprojectoptions + updated specs.Feedback and comments are greatly appreciated 😺