fix: remove dictionary count limit from viceroy #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennismartensson
previously approved these changes
Feb 15, 2023
JakeChampion
force-pushed
the
jake/jake/dict-limit
branch
from
0b003be to
789c6f1
Compare
this limit can be raised per service on c-at-e. if the limit was raised on a customers service, then the customer could no longer run their application locally with viceroy. by removing he limit in viceroy, customers who have a himit dictionary limit would be able to run their application locally.
JakeChampion
force-pushed
the
jake/jake/dict-limit
branch
from
789c6f1 to
e9b642e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this limit can be raised per service on c-at-e. if the limit was raised on a customers service, then the customer could no longer run their application locally with viceroy. by removing he limit in viceroy, customers who have a himit dictionary limit would be able to run their application locally.
I hit this issue in my own project which uses a dictionary containing ~3400 keys