Add guest-profiler support to serve mode #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why the |
JakeChampion
force-pushed
the
profile-serve
branch
from
b1cb5bd to
a459c40
Compare
JakeChampion
reviewed
Aug 9, 2023
Comment on lines
-368
to
+395
| self, | ||
| program_name: &str, | ||
| args: &[String], | ||
| guest_profile_path: Option<&PathBuf>, | ||
| ) -> Result<(), anyhow::Error> { | ||
| pub async fn run_main(self, program_name: &str, args: &[String]) -> Result<(), anyhow::Error> { |
There was a problem hiding this comment.
Note: We need to release this as 0.7.x since we are changing the signature of a public crate function
JakeChampion
approved these changes
Aug 9, 2023
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
* Add guest-profiler support to serve mode * Fix trap-test * Fix doc-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.