Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubbed-out values for remaining FASTLY_ environment variables. #337

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

katef
Copy link
Contributor

@katef katef commented Dec 13, 2023

We already had a few here, with values that make sense. I expect these ones were missing because their values don't make sense, I'm just hardcoding something reasonable. What matters for me is that they're present at all, and to match production ecp in what's present.

My intention is that a user would then be able to override these stub values by explicitly setting things from the config file (see #336 about that), but that there's no way to ever have these not set. Because that matches production.

We already had a few here, with values that make sense. I expect these ones were missing because their values don't make sense, I'm just hardcoding something reasonable. What matters for me is that they're present at all, and to match production ecp in what's present.

My intention is that a user would then be able to override these stub values by explicitly setting things from the config file (see #336 about that), but that there's no way to ever have these not set. Because that matches production.
@katef katef added the feature-prod Related to matching the production C@E environment label Dec 13, 2023
@katef katef marked this pull request as ready for review December 13, 2023 17:43
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, with a modification to the comment about the env vars. Thanks!

lib/src/linking.rs Show resolved Hide resolved
@katef katef merged commit 8f2ea50 into main Dec 13, 2023
7 checks passed
@katef katef deleted the kate/336-placeholder-env-vars branch December 13, 2023 17:53
cmckendry pushed a commit to 1stdibs/Viceroy that referenced this pull request Feb 8, 2024
…fastly#337)

We already had a few here, with values that make sense. I expect these ones were missing because their values don't make sense, I'm just hardcoding something reasonable. What matters for me is that they're present at all, and to match production ecp in what's present.

My intention is that a user would then be able to override these stub values by explicitly setting things from the config file (see fastly#336 about that), but that there's no way to ever have these not set. Because that matches production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-prod Related to matching the production C@E environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants