Upgrade to wasmtime-20, and switch to wasmtime-wasi #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/wasmtime-20
branch
from
5d80cf4 to
0b9c0c7
Compare
This was referenced May 7, 2024
Closed
athomason
reviewed
May 7, 2024
acw
approved these changes
May 8, 2024
| @@ -102,7 +105,7 @@ pub(crate) fn create_store( | |||
| store.set_epoch_deadline(1); | |||
| store.epoch_deadline_callback(|mut store| { | |||
| if let Some(mut prof) = store.data_mut().guest_profiler.take() { | |||
| prof.sample(&store); | |||
| prof.sample(&store, std::time::Duration::ZERO); | |||
There was a problem hiding this comment.
I'm just going to highlight this, because a sample duration of zero kind of confuses me. I guess it can't be the epoch time because we may have taken other samples during that epoch? Is there a reason ("because it's too slow, Adam") to not keep a time-since-last-sample, or something?
There was a problem hiding this comment.
This delta parameter is the amount of cpu time that was taken since the last sample call. Passing zero is called out as okay in the docs for cases where cpu usage information isn't needed. We can always start tracking that for more precise profiles in the future, but this seemed like a reasonable first step :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the wasmtime dependency to wasmtime-20, and also remove the dependency on wasi-common in favor of using the preview1-on-preview2 implementation provided by wasmtime-wasi.
There was also a change in wiggle's borrow checker for the 20.0.0 release that affected our host call implementations directly: borrows are no longer to a region, but the whole guest memory. This caused a bit of churn in the wiggle_abi tree, and I'm not completely certain that all issues have been resolved, as the test suite can only test so many paths through the host calls. For reference, here's the wiggle refactoring PR in wasmtime: bytecodealliance/wasmtime#8277.