Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add condition commands #1008

Merged
merged 4 commits into from
Sep 11, 2023
Merged

add condition commands #1008

merged 4 commits into from
Sep 11, 2023

Conversation

noguxun
Copy link
Contributor

@noguxun noguxun commented Sep 8, 2023

Fixes #841

@Integralist Integralist added the enhancement New feature or request label Sep 8, 2023
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Just two minor edits required to be made and then this will be good to go.

One other thing was that the associated API is a VCL Object and so I'm wondering if instead of fastly condition ... it should be nested under the vcl package like 'custom' and 'snippet' are so the command changes to fastly vcl condition (I think that might make it clearer what a condition is).

Thanks!

pkg/commands/condition/create.go Outdated Show resolved Hide resolved
pkg/commands/condition/list.go Outdated Show resolved Hide resolved
@noguxun
Copy link
Contributor Author

noguxun commented Sep 11, 2023

Hi @Integralist , I've made a new commit according to your review.

@noguxun noguxun requested a review from Integralist September 11, 2023 12:09
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple of minor tweaks required.

pkg/app/run_test.go Outdated Show resolved Hide resolved
pkg/commands/vcl/condition/create.go Outdated Show resolved Hide resolved
noguxun and others added 2 commits September 11, 2023 21:44
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉❤️

LGTM. Thanks!

@Integralist Integralist merged commit 4f60b2b into fastly:main Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Please add CONDITIONS to the CLI
2 participants