Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds PublicKey field to S3 #114

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Adds PublicKey field to S3 #114

merged 2 commits into from
Jun 4, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented Jun 4, 2020

Proposed Change(s)

  • Add PublicKey field to all S3 CRUD operations.

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-s3-publickey && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested review from ezkl and phamann June 4, 2020 14:42
@mccurdyc mccurdyc added the enhancement New feature or request label Jun 4, 2020
mccurdyc
mccurdyc commented Jun 4, 2020
View reviewed changes
pkg/logging/s3/s3_test.go Outdated Show resolved Hide resolved
@mccurdyc mccurdyc mentioned this pull request Jun 4, 2020
Merged
phamann
phamann approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

mccurdyc added 2 commits June 4, 2020 11:30
@mccurdyc
logging/s3: add supported PublicKey field to all CRUD operations.
5ccb1f1 
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc
fix bug in tests where they were not properly testing missing fields
df48ee6 
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

mccurdyc commented Jun 4, 2020

Force-pushed rebasing master.

@mccurdyc mccurdyc merged commit 48fb0b3 into fastly:master Jun 4, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-s3-publickey branch June 4, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

@ezkl ezkl Awaiting requested review from ezkl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann