Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persistence of author string to fastly.toml #12

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented Mar 27, 2020

TL;DR

The new interactive init (#5) introduced a rendering bug when the default author email is persisted to the fastly.toml authors field which resulted in extraneous square brackets inside the string.

Before:
authors = [" [test@example.com]"]

After:
authors = ["test@example.com"]

@phamann phamann requested a review from peterbourgon March 27, 2020 15:10
@phamann phamann merged commit 96c6300 into master Mar 27, 2020
@phamann phamann deleted the phamann/fix-authors branch March 27, 2020 15:23
@phamann phamann added the bug Something isn't working label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants