fix(compute/serve): don't fail the serve workflow if github errors #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
approved these changes
Jul 11, 2024
Integralist
force-pushed
the
integralist/dont-fail-serve
branch
from
75222aa to
61f2cf6
Compare
kpfleming
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users on Darwin/AMD64 would see an error when running
compute serve.This would be when the CLI attempts to call the GitHub API to check for the latest version of the Viceroy tool.
Viceroy currently doesn't support this ARCH and so the endpoint would return a 5xx which the CLI would then return to the user and stop the overall process from running.
We shouldn't stop the process because the user could have a local version of Viceroy already installed and ready to use.