Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): Fix build checks for JavaScript code #1354

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix(npm): Fix build checks for JavaScript code #1354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e030a31
fix(npm): Fix for javascript.lang.security.audit.unsafe-formatstring.…
harmony7 Dec 4, 2024
ca054f9
fix(npm): Output correct object in error message
harmony7 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions npm/@fastly/cli/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ let response = await fetch(
);
if (!response.ok) {
console.error(
'%s %o',
`Response from https://api.github.com/repos/fastly/cli/releases/tags/${tag} was not ok`,
response
);
Expand All @@ -87,10 +88,11 @@ let assets = await fetch(
);
if (!assets.ok) {
console.error(
'%s %o',
`Response from https://api.github.com/repos/fastly/cli/releases/${id}/assets was not ok`,
assets
);
console.error(await response.text());
console.error(await assets.text());
process.exit(1);
}
assets = await assets.json();
Expand Down Expand Up @@ -120,7 +122,11 @@ for (const info of packages) {
const browser_download_url = asset.browser_download_url;
const archive = await fetch(browser_download_url);
if (!archive.ok) {
console.error(`Response from ${browser_download_url} was not ok`, archive);
console.error(
'%s %o',
`Response from ${browser_download_url} was not ok`,
archive
);
console.error(await response.text());
process.exit(1);
}
Expand Down
Loading