fix(sso): Ensure that only one authentication cycle is started. #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'sso' command, when run against a profile with an expired refresh token, would cause two authentication cycles to be started: one by the CLI core before the 'sso' command itself was executed, and then another by the 'sso' command. The second cycle would fail and result in an 'extra' browser tab/window with an error message of "ERROR: no authorization code returned". While the authentication was successful and the new refresh/access/session tokens were stored, this confused the user of the CLI.
Integralist
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'sso' command, when run against a profile with an expired refresh token, would cause two authentication cycles to be started: one by the CLI core before the 'sso' command itself was executed, and then another by the 'sso' command. The second cycle would fail and result in an 'extra' browser tab/window with an error message of "ERROR: no authorization code returned". While the authentication was successful and the new refresh/access/session tokens were stored, this confused the user of the CLI.