Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #1377

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

SahibYar
Copy link
Contributor

Updated dependencies

Testing

I executed make all after updating dependencies, and output is same as main branch

output.txt

@kpfleming
Copy link
Contributor

This looks fine to me, thanks for the contribution! Would you be willing to include a .github/dependabot.yml file in this PR to enable 'version' update PRs from Dependabot? That would keep us from getting out of date again, as we will get automatic PRs for new dependency versions.

@SahibYar
Copy link
Contributor Author

The Dependabot configuration is already in place, as seen here: Dependabot.yml in the Fastly CLI repository.

@kpfleming
Copy link
Contributor

Indeed it is, my apologies. The problem appears to be that the configuration does not allow Dependabot to update 'indirect' dependencies, and the updates you've offered in this PR are primarily indirect dependencies. This can be cured by adding this block to the Dependabot configuration for the gomod package-ecosystem:

    allow:
      # Allow both direct and indirect updates for all packages.
      - dependency-type: "all"

@kpfleming kpfleming merged commit 314868c into fastly:main Jan 24, 2025
6 checks passed
@SahibYar SahibYar deleted the refactor/updating-dependencies branch January 27, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants