Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment for --use-ssl flag #6

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Fix comment for --use-ssl flag #6

merged 1 commit into from
Mar 12, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented Mar 11, 2020

TL;DR

Fixes a copy/pasta typo, copy of #4 due to github auth issues.

@phamann
Fix comment for --use-ssl flag
f46ef9f 
Co-authored-by: denen99 <adamd@fastly.com">
@phamann phamann requested review from peterbourgon and denen99 March 11, 2020 10:32
@phamann phamann mentioned this pull request Mar 11, 2020
Closed
peterbourgon
peterbourgon approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Is the double-$$ in the fossa target in the Makefile intentional?

@phamann phamann merged commit 6468061 into master Mar 12, 2020
@phamann phamann deleted the phamann/fix-backend-comment branch March 12, 2020 09:04
@phamann phamann added the bug Something isn't working label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

@denen99 denen99 Awaiting requested review from denen99

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phamann @peterbourgon