Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe subcommand consistent --name short flag -d -> -n #85

Merged
merged 1 commit into from
May 21, 2020
Merged

Describe subcommand consistent --name short flag -d -> -n #85

merged 1 commit into from
May 21, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented May 21, 2020 •
edited
Loading

Proposed Change(s)

  • Consistently use of -n as the short flag for --name (previously was -d that got copy-pasted ubiquitously).
$ find . -type f -name "describe.go" -exec sed -i "s/\"name\", \(.*\).Short('d')/\"name\", \1.Short('n')/g" {} \;`

Validation

  • make test

@mccurdyc mccurdyc requested a review from phamann May 21, 2020 15:08
@mccurdyc mccurdyc changed the title [logging/domain] - describe --name short flag -n [logging/domain/backend] - describe --name short flag -n May 21, 2020
phamann
phamann approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - I appreciate you doing this

@mccurdyc mccurdyc changed the title [logging/domain/backend] - describe --name short flag -n Describe subcommand consistent --name short flag -d -> -n May 21, 2020
@mccurdyc
all: update describe subcommands to use -n for --name short flag
ec3e199 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed squashing into single commit.

@mccurdyc mccurdyc merged commit ba0e77f into fastly:master May 21, 2020
@mccurdyc mccurdyc deleted the mccurdyc/name-consistent-short-flag branch May 21, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann