Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest fastly.toml manifest data model #907

Merged
merged 14 commits into from
Apr 17, 2023

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Apr 13, 2023

This PR addresses a few separate issues...

  1. Renaming [setup.dictionaries] and [local_server.dictionaries] to the config_stores equivalent.
  2. Warning the user if their config contains [setup.dictionaries] and provide relevant remediation steps.
  3. Splitting the manifest package up into separate files for easier maintenance.
  4. Refactor the manifest tests.
  5. Refactor the manifest Read() method, which includes...
    • Removing a bug fix for a very old v0.25.0 issue.
    • Not auto-updating manifest_version (it made incorrect assumptions about manifest interface changes).
  6. Updating error remediation message to reference the correct documentation link.

WARNING: We've bumped manifest_version to a new version 3 but we're waiting for @triblondon to land an internal documentation update that bumps the version before we cut a new release.

@Integralist Integralist added the enhancement New feature or request label Apr 13, 2023
Copy link
Collaborator

@awilliams-fastly awilliams-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/manifest/data.go Outdated Show resolved Hide resolved
pkg/manifest/version.go Outdated Show resolved Hide resolved
@Integralist Integralist force-pushed the integralist/auto-migrate-object-store branch from 75c8526 to 58e6012 Compare April 17, 2023 10:59
@Integralist Integralist merged commit 210e2a7 into main Apr 17, 2023
@Integralist Integralist deleted the integralist/auto-migrate-object-store branch April 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants