Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend surrogate keys instead of replacing them #719

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Extend surrogate keys instead of replacing them #719

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4199d13
Append surrogate keys instead of replacing them
herzog31 Nov 20, 2024
2094df6
Append surrogate keys instead of replacing them
herzog31 Nov 21, 2024
5d38431
Merge branch 'master' into extend-surrogate-keys
herzog31 Nov 21, 2024
2575af9
Merge branch 'master' into extend-surrogate-keys
herzog31 Dec 17, 2024
60c5081
Adapt surrogate keys only on outermost Fastly node
herzog31 Dec 19, 2024
58237c2
Merge branch 'master' of github.com:fastly/fastly-magento2 into exten…
herzog31 Dec 19, 2024
f8af53c
Update etc/vcl_snippets/fetch.vcl
herzog31 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions etc/vcl_snippets/fetch.vcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,30 @@
if (beresp.ttl > 0s && (req.request == "GET" || req.request == "HEAD") && !req.http.x-pass ) {
unset beresp.http.set-cookie;

# init surrogate keys
if (beresp.http.X-Magento-Tags) {
set beresp.http.Surrogate-Key = beresp.http.X-Magento-Tags " text";
} else {
set beresp.http.Surrogate-Key = "text";
}
# init surrogate keys if on outermost node
if (fastly.ff.visits_this_service == 0 && req.restarts == 0) {
if (beresp.http.X-Magento-Tags) {
if (beresp.http.Surrogate-Key) {
set beresp.http.Surrogate-Key = beresp.http.Surrogate-Key " " beresp.http.X-Magento-Tags " text";
} else {
set beresp.http.Surrogate-Key = beresp.http.X-Magento-Tags " text";
}
} else {
if (beresp.http.Surrogate-Key) {
set beresp.http.Surrogate-Key = beresp.http.Surrogate-Key " text";
} else {
set beresp.http.Surrogate-Key = "text";
}
}

# set surrogate keys by content type if they are image/script or CSS
if (beresp.http.Content-Type ~ "(image|script|css)") {
set beresp.http.Surrogate-Key = re.group.1;
# set surrogate keys by content type if they are image/script or CSS
if (beresp.http.Content-Type ~ "(image|script|css)") {
if (beresp.http.Surrogate-Key) {
set beresp.http.Surrogate-Key = beresp.http.Surrogate-Key " " re.group.1;
} else {
set beresp.http.Surrogate-Key = re.group.1;
}
}
}
}

Expand Down