Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources for Custom TLS and Platform TLS products #364

Merged
merged 29 commits into from
Feb 17, 2021

Commits on Feb 8, 2021

  1. Configuration menu
    Copy the full SHA
    94a4df6 View commit details
    Browse the repository at this point in the history
  2. TLS Configuration Data Source

    wjam authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1f75279 View commit details
    Browse the repository at this point in the history
  3. TLS Custom Certificate Resource

    wjam authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    bfc483f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f3f9a6 View commit details
    Browse the repository at this point in the history
  5. TLS Custom Certificate Data Source

    Also add sweepers for TLS certificates and private keys to easily clean up resources leaked during any failed tests.
    wjam authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    8a4ba5f View commit details
    Browse the repository at this point in the history
  6. TLS Activation Resource

    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    f47fa90 View commit details
    Browse the repository at this point in the history
  7. TLS Activation Data Source

    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1b74e16 View commit details
    Browse the repository at this point in the history
  8. TLS Private Key IDs Data Source

    wjam authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    444c610 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d2dcebb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    73deb71 View commit details
    Browse the repository at this point in the history
  11. TLS Activation IDs Data Source

    trentrosenbaum authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7594f3a View commit details
    Browse the repository at this point in the history
  12. Change test names to use underscore

    Terraform testing style guide seems to suggest camel case is used for
    the main test name then an underscore separates different variations of
    it.
    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    f9dc6d2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    67499dd View commit details
    Browse the repository at this point in the history
  14. TLS Platform Certificate Resource

    wjam authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    b88fca1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    31acfc6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1eb8f3a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e94768b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a917559 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    23f082d View commit details
    Browse the repository at this point in the history
  20. Bring in changes from upstream and modify new code to match

    Main changes were moving docs generation to tfplugindocs, and updating
    the go-fastly SDK to v3. I added some changes to the upstream docs
    generation to avoid having to globally install tfplugindocs. This was
    also done upstream so I had to do some large merge conflict resolution
    in this commit to combine the similar but different updates.
    
    One commit message related to vendoring tfplugindocs was:
    
    > Don't cache dependencies in github PR workflow, instead rely on /vendor
    >
    > Including the tfplugindocs module in vendor means it's updating with `go
    > mod vendor` along with the other libraries used. When running `go
    > install`, this vendored copy is used, and installed to a project-local
    > /bin directory. This enables the version of tfplugindocs used to be
    > independent of other go projects installed on one's system.
    >
    > This change means `make dependencies` is no longer used, and isn't
    > needed in the github PR workflow. Furthermore, the source code for the
    > tool is included in the /vendor already so the caching of ~/go/* isn't
    > required either.
    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    a56c1a3 View commit details
    Browse the repository at this point in the history
  21. Stylistic tweaks to make resources more aligned

    A couple naming/structure things resulting from different people writing the code. Have just tidied them up before PRing.
    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0d68aec View commit details
    Browse the repository at this point in the history
  22. Add TLSCLientCert and TLSClientKey options for splunk logging (fastly…

    …#353)
    
    * Add TLSCLientCert and TLSClientKey options for splunk logging
    
    * Add some comments to clarify the usage splunk test tls cert values
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    * Update fastly/block_fastly_service_v1_splunk_test.go
    
    Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
    2 people authored and bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1e2e02e View commit details
    Browse the repository at this point in the history
  23. Update go-fastly reference

    bengesoff committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    a6a117a View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    12afcea View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Support multiple certificates in platform certificate intermediates_blob

    The intermediates_blob field of the fastly_tls_platform_certificate
    resource can contain PEM blocks representing an arbitrary length chain
    of certificates. The validation function for this field has been updated
    to reflect this. It now loops through the provided string and checks
    that each block it finds matches the expected block type until it
    reaches the end of the string. Similarly the validation function for one
    single block has been updated to fail if the string contains more than
    one PEM block.
    bengesoff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    ecfcbbe View commit details
    Browse the repository at this point in the history
  2. Use allow_untrusted_root in platform certificate update function

    Was only used in creation function but should have also been used
    in update too.
    bengesoff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b14967f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Update go-fastly reference to v3.3.0

    Also removed the `replace` directive in the go.mod to remove dependency
    on opencredo fork.
    bengesoff committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    9ff3b8f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. First updates from PR feedback

    - removal of unneeded .gitignore entry
    - removal of superfluous whitespace in docs example block
    - conversion of TypeList to TypeSet in plural data sources' `ids` field
    - a couple typo fixes here and there
    - removal of Set function for controlling set hashing, unneeded
    - consolidation of function naming to include "Fastly" before resource
      name
    - fix some acctest.RandomWithPrefix with duplicate prefix
    - clarify some comments
    - add some checks in testAcc.*Exists functions when accessing the map of
      resources in state to avoid a panic if resource not found
    bengesoff committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    faca4d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Make tfplugindocs location configurable with flag instead of PATH

    Add a -tfplugindocsPath command line argument to the parsing script to
    make it a bit more robust than dynamically setting the PATH variable in
    the Makefile. Defaults to local bin, as the Makefile expects, but I
    still set the argument in the Makefile in case someone modifies the BIN
    variable.
    bengesoff committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    255b34b View commit details
    Browse the repository at this point in the history