Managed TLS Subscriptions Resources #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengesoff
force-pushed
the
tls-managed
branch
4 times, most recently
from
9e35a2f
to
6fa7278
Compare
bengesoff
force-pushed
the
tls-managed
branch
from
6fa7278
to
2c1fccb
Compare
* Tweak test function name TLs -> TLS * Add Fastly TLS Subscription resource * Add create, read, and delete functions to TLS subscription * Add TLS subscription test sweeper * Add more attributes to TLS subscription resource and add test checks * Add TLS Subscription Import * PR feedback fixes * TLS Subscription resource docs * Update go-fastly reference * Update go-fastly reference to merged PR Delete TLS activations in TLS Subscription Delete function The subscription silently creates an activation when it reaches "issued" state. This prevents the subscription from being deleted directly, as it complains about the subscription having "enabled TLS domains". To prevent this, before deleting the subscription, I have added a query to find all TLS activations on the TLS domain associated with the subscription and delete those first. In testing, this allowed deletion of the subscription even after the domain validation succeeded.
…iption It seemed like the recommended/most common option so making it a separate Map object, with no filtering/looping required, made the most sense for ease of use. Leaving the other options in a set allows the user to specify their own filters in line with their requirements.
…activation joint deletion check
Previously was always effectively "force destroying" by unconditionally deleting all associated TLS activations. I have been introduced to the "force" flag in the API which is a more elegant way to do the same thing. Having added that to the go-fastly SDK, I am taking advantage of that here, and also making it optional behaviour so that the user has to choose to take the risk of disabling production traffic.
Needed to pass provider validation checks. Will be removed when PATCH endpoint used as there will be an Update function and it'll be happy.
bengesoff
force-pushed
the
tls-managed
branch
from
2c1fccb
to
4fc511a
Compare
bengesoff
force-pushed
the
tls-managed
branch
from
4fc511a
to
b689343
Compare
Integralist
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
@bengesoff Thanks for the PR! Just a couple of minor comments/questions. Otherwise approved.
Integralist
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 new resources:
fastly_tls_subscriptionfastly_tls_subscription_validation3 new data sources:
fastly_tls_domainfastly_tls_subscriptionfastly_tls_subscription_idsThis PR depends on #364.
Does not include support for
PATCHendpoint yet, will add in a separate PR.